[webkit-reviews] review granted: [Bug 224496] Support Commit revision identifiter in the Chart : [Attachment 425889] Patch

[bugzilla-daemon at webkit.org]

dewei_zhu at apple.com has granted Zhifei Fang <zhifei_fang at apple.com>'s request
for review:
Bug 224496: Support Commit revision identifiter in the Chart
https://bugs.webkit.org/show_bug.cgi?id=224496

Attachment 425889: Patch

https://bugs.webkit.org/attachment.cgi?id=425889&action=review




--- Comment #2 from dewei_zhu at apple.com ---
Comment on attachment 425889
  --> https://bugs.webkit.org/attachment.cgi?id=425889
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425889&action=review

r=me

> Websites/perf.webkit.org/ChangeLog:7
> +	   In the measurement-set, we include the commit info but not the
commit revision identifier column.
> +	   Make the API returen the commit revision identifier as part of the
commit data.

Nit: this should below `Reviewed by section`
Typo returen -> return

> Websites/perf.webkit.org/server-tests/api-measurement-set-tests.js:501
> +	    assert.deepStrictEqual(format(response['formatMap'],
currentRows[1]), {

Nit: this indentation doesn't look right.