[webkit-reviews] review granted: [Bug 224445] [macOS] Refactor logic for presenting the shared QLPreviewPanel when revealing an image : [Attachment 425781] Patch

[bugzilla-daemon at webkit.org]

Andy Estes <aestes at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 224445: [macOS] Refactor logic for presenting the shared QLPreviewPanel
when revealing an image
https://bugs.webkit.org/show_bug.cgi?id=224445

Attachment 425781: Patch

https://bugs.webkit.org/attachment.cgi?id=425781&action=review




--- Comment #3 from Andy Estes <aestes at apple.com> ---
Comment on attachment 425781
  --> https://bugs.webkit.org/attachment.cgi?id=425781
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425781&action=review

> Source/WebKit/UIProcess/API/mac/WKWebViewMac.mm:46
> + at class QLPreviewPanel;

Do you still need this since WebViewImpl.h also declares QLPreviewPanel?

> Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm:139
> +#import "WKImageExtractionPreviewController.h"

Could this be imported unconditionally?