[webkit-reviews] review granted: [Bug 224489] Allow text tracks to purge cues outside of the buffered range : [Attachment 425882] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 224489: Allow text tracks to purge cues outside of the buffered range
https://bugs.webkit.org/show_bug.cgi?id=224489

Attachment 425882: Patch

https://bugs.webkit.org/attachment.cgi?id=425882&action=review




--- Comment #3 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 425882
  --> https://bugs.webkit.org/attachment.cgi?id=425882
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425882&action=review

r=me with nit:

> Source/WebCore/html/track/InbandDataTextTrack.h:48
> +    bool purgesCuesFromUnbufferedRanges() const final { return true; }

Nit: This confused me on initial reading, which I parsed as "purge cues from
unbuffered ranges". Maybe "shouldPurgeCuesFromUnbufferedRanges()"?