[webkit-reviews] review granted: [Bug 224359] [GTK][WPE] Add a property to the WebKitWebView indicating whether the web process is responsive : [Attachment 425876] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Miguel Gomez
<magomez at igalia.com>'s request for review:
Bug 224359: [GTK][WPE] Add a property to the WebKitWebView indicating whether
the web process is responsive
https://bugs.webkit.org/show_bug.cgi?id=224359

Attachment 425876: Patch

https://bugs.webkit.org/attachment.cgi?id=425876&action=review




--- Comment #10 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 425876
  --> https://bugs.webkit.org/attachment.cgi?id=425876
Patch

Patch LGTM, with a couple of nits to take into account before landing :-)

View in context: https://bugs.webkit.org/attachment.cgi?id=425876&action=review

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:1341
> +

This added empty line is not really needed.

> Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:4737
> +    g_object_notify(G_OBJECT(webView), "is-web-process-responsive");

I see that you have rebased on top of the changes from bug #224366 (nice!),
but I think you might have missed changing this property notification to
use _notify_by_pspec():

  g_object_notify_by_pspec(G_OBJECT(webView),
sObjProperties[PROP_IS_WEB_PROCESS_RESPONSIVE]);

Please change this before landing.