[webkit-reviews] review granted: [Bug 224473] [JSC] Remove CodeBlock::m_constantsSourceCodeRepresentation : [Attachment 425837] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 12 23:40:05 PDT 2021


Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 224473: [JSC] Remove CodeBlock::m_constantsSourceCodeRepresentation
https://bugs.webkit.org/show_bug.cgi?id=224473

Attachment 425837: Patch

https://bugs.webkit.org/attachment.cgi?id=425837&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 425837
  --> https://bugs.webkit.org/attachment.cgi?id=425837
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425837&action=review

r=me

> Source/JavaScriptCore/ChangeLog:13
> +	   And it array is effectively accessed only when compiling DFG code.
So we should remove copy of that in CodeBlock, and

/it array/the array/


More information about the webkit-reviews mailing list