[webkit-reviews] review granted: [Bug 224093] ICU 69 Deprecates ubrk_safeClone in favor of ubrk_clone : [Attachment 425820] Patch

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <ysuzuki at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 224093: ICU 69 Deprecates ubrk_safeClone in favor of ubrk_clone
https://bugs.webkit.org/show_bug.cgi?id=224093

Attachment 425820: Patch

https://bugs.webkit.org/attachment.cgi?id=425820&action=review




--- Comment #8 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 425820
  --> https://bugs.webkit.org/attachment.cgi?id=425820
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425820&action=review

r=me with some comments.

> Source/JavaScriptCore/runtime/IntlWorkaround.cpp:41
> +#if HAVE(ICU_UBRK_CLONE)
> +#define U_HIDE_DRAFT_API 1
> +#endif

I think we do not need to make it back since this cpp file is isolated.

> Source/JavaScriptCore/runtime/IntlWorkaround.cpp:50
> +return ubrk_clone(iterator, status);

4 spaces for indentation.

> Source/JavaScriptCore/runtime/IntlWorkaround.cpp:52
> +return ubrk_safeClone(iterator, nullptr, nullptr, status);

Ditto.