[webkit-reviews] review granted: [Bug 224402] Force the WebAuthn compatible mode to always show UI : [Attachment 425672] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 12 16:24:03 PDT 2021


Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 224402: Force the WebAuthn compatible mode to always show UI
https://bugs.webkit.org/show_bug.cgi?id=224402

Attachment 425672: Patch

https://bugs.webkit.org/attachment.cgi?id=425672&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 425672
  --> https://bugs.webkit.org/attachment.cgi?id=425672
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425672&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalConnection.mm:102
> +#if USE(APPLE_INTERNAL_SDK)

Does this need a macOS check? or is it correct for iOS, too?


More information about the webkit-reviews mailing list