[webkit-reviews] review denied: [Bug 224390] [CoreIPC] Crash in logDiagnosticMessage code : [Attachment 425803] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has denied Julian Gonzalez
<julian_a_gonzalez at apple.com>'s request for review:
Bug 224390: [CoreIPC] Crash in logDiagnosticMessage code
https://bugs.webkit.org/show_bug.cgi?id=224390

Attachment 425803: Patch

https://bugs.webkit.org/attachment.cgi?id=425803&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 425803
  --> https://bugs.webkit.org/attachment.cgi?id=425803
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425803&action=review

> Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:428
> +	   || decoder.messageName() ==
Messages::WebPageProxy::LogDiagnosticMessageFromWebProcess::name()

That's not quite right. You'll need to provide implementations for these
logging functions on ProvisionalPageProxy which do the MESSAGE_CHECKS with
m_process and THEN call the public logging functions on WebPageProxy. This is
important because WebPageProxy and ProvisionalPageProxy use different
processes. You wouldn't want a bad IPC from the provisional process to kill the
committed process.