[webkit-reviews] review granted: [Bug 224451] Remove support for NPAPI plugins in WKWebView : [Attachment 425788] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 224451: Remove support for NPAPI plugins in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=224451

Attachment 425788: Patch

https://bugs.webkit.org/attachment.cgi?id=425788&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 425788
  --> https://bugs.webkit.org/attachment.cgi?id=425788
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425788&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKPreferences.mm:-1520
> -    _preferences->setPluginsEnabled(plugInsEnabled);

I think we should add a RELEASE_LOG_FAULT() when this is called with
plugInsEnabled. This should make issues way more obvious in the sysdiagnoses.