[webkit-reviews] review granted: [Bug 224430] Add support for RTCEncodedFrame metadata : [Attachment 425737] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 224430: Add support for RTCEncodedFrame metadata
https://bugs.webkit.org/show_bug.cgi?id=224430

Attachment 425737: Patch

https://bugs.webkit.org/attachment.cgi?id=425737&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 425737
  --> https://bugs.webkit.org/attachment.cgi?id=425737
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425737&action=review

>
Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpTransformableFrame.cpp
:114
> +    return { frameId, WTFMove(dependencies), metadata.GetWidth(),
metadata.GetHeight(), metadata.GetSpatialIndex(), metadata.GetTemporalIndex(),
m_rtcFrame->GetSsrc(), { } };

Will we eventually support contributingSources? If so, it would be good to have
a bug and reference it here.