[webkit-reviews] review granted: [Bug 224301] Add test to verify _WKCustomHeaderFields is used with HTTP requests : [Attachment 425449] Patch

Mon Apr 12 07:55:26 PDT 2021

youenn fablet <youennf at gmail.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 224301: Add test to verify _WKCustomHeaderFields is used with HTTP requests
https://bugs.webkit.org/show_bug.cgi?id=224301

Attachment 425449: Patch

https://bugs.webkit.org/attachment.cgi?id=425449&action=review


--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 425449
  --> https://bugs.webkit.org/attachment.cgi?id=425449
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425449&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:1196
> +    NSString *string = [NSString stringWithFormat:@"<script>function
bodyloaded(){fetch('%@',{mode:'no-cors'}).then(()=>{alert('loaded')}).catch((e)
=>{alert('caught '+e)})}</script><body onload='bodyloaded()'/>",
server.request().URL];

Would be interesting to do it with CORS so that:
- injecting this custom header does not trigger preflight requests for all CORS
requests
- ensuring preflight requests get that header