[webkit-reviews] review granted: [Bug 224256] [ macOS wk2 ] webrtc/libwebrtc/release-while-creating-offer.html is a flakey text failure : [Attachment 425723] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 224256: [ macOS wk2 ] webrtc/libwebrtc/release-while-creating-offer.html is
a flakey text failure
https://bugs.webkit.org/show_bug.cgi?id=224256

Attachment 425723: Patch

https://bugs.webkit.org/attachment.cgi?id=425723&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 425723
  --> https://bugs.webkit.org/attachment.cgi?id=425723
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425723&action=review

> Source/WTF/wtf/PlatformHave.h:-951
> -
> -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 110000 &&
__MAC_OS_X_VERSION_MAX_ALLOWED >= 110300) \
> -    || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MAX_ALLOWED >= 140500) \
> -    || (PLATFORM(APPLETV) && __TV_OS_VERSION_MAX_ALLOWED >= 140500) \
> -    || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MAX_ALLOWED >= 70400)
> -#define HAVE_VM_FLAGS_PERMANENT 1
> -#endif
> -
> -#if (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000) \
> -    || (PLATFORM(IOS) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) \
> -    || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 80000) \
> -    || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 150000)
> -#define HAVE_CFNETWORK_NSURLSESSION_ATTRIBUTED_BUNDLE_IDENTIFIER 1
> -#endif

I don't think you meant to include this