[webkit-reviews] review granted: [Bug 196606] [GStreamer][WebRTC] An audio track should be muted when capture is interrupted by the OS. : [Attachment 425724] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 196606: [GStreamer][WebRTC] An audio track should be muted when capture is
interrupted by the OS.
https://bugs.webkit.org/show_bug.cgi?id=196606

Attachment 425724: Patch

https://bugs.webkit.org/attachment.cgi?id=425724&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 425724
  --> https://bugs.webkit.org/attachment.cgi?id=425724
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425724&action=review

>
Source/WebCore/platform/mediastream/gstreamer/GStreamerAudioCaptureSource.h:56
> +    bool interrupted() const final;

isInterrupted

> Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:188
> +    gboolean drop;

isDropping

> Source/WebCore/platform/mediastream/gstreamer/GStreamerCapturer.cpp:193
> +void GStreamerCapturer::setInterrupted(bool interrupted)

isInterrupted.

>
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.
cpp:143
> +void MockRealtimeAudioSourceGStreamer::setInterruptedForTesting(bool
interrupted)

isInterrupted

>
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.
h:48
> +    bool interrupted() const final { return m_interrupted; };

isInterrupted

>
Source/WebCore/platform/mediastream/gstreamer/MockRealtimeAudioSourceGStreamer.
h:56
> +    bool m_interrupted { false };

m_isInterrupted