[webkit-reviews] review granted: [Bug 224410] Simplify WebKitTestRunner preference reset to be more like DRT : [Attachment 425711] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 224410: Simplify WebKitTestRunner preference reset to be more like DRT
https://bugs.webkit.org/show_bug.cgi?id=224410

Attachment 425711: Patch

https://bugs.webkit.org/attachment.cgi?id=425711&action=review




--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 425711
  --> https://bugs.webkit.org/attachment.cgi?id=425711
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425711&action=review

> Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h:54
> +WK_EXPORT void WKPreferencesStartBatchingUpdates(WKPreferencesRef);
> +WK_EXPORT void WKPreferencesEndBatchingUpdates(WKPreferencesRef);

What’s the story on adding new C API (including private/SPI) vs.
Objective-C/Swift API? Are there cross-platform reason to keep adding to the C
API? I know that on Apple platforms we want the Objective-C/Swift to have
parity or be a superset.

> Tools/WebKitTestRunner/TestOptions.cpp:60
>	       { "AcceleratedDrawingEnabled", false },

Is there some way to share this list with DumpRenderTree?