[webkit-reviews] review granted: [Bug 224409] initial horizontal scrollbar positions for RTL elements is wrong : [Attachment 425693] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Cameron McCormack (:heycam)
<heycam at apple.com>'s request for review:
Bug 224409: initial horizontal scrollbar positions for RTL elements is wrong
https://bugs.webkit.org/show_bug.cgi?id=224409

Attachment 425693: Patch

https://bugs.webkit.org/attachment.cgi?id=425693&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 425693
  --> https://bugs.webkit.org/attachment.cgi?id=425693
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425693&action=review

> Source/WebCore/rendering/RenderLayerScrollableArea.cpp:1032
> +	   m_hBar->offsetDidChange();

This is unconditionally called, even if the code above sets the origin to the
same value it’s already set to. Should there be a check?