[webkit-reviews] review granted: [Bug 224412] WebProcessPool should store Vector<Ref<WebProcessProxy>> instead of Vector<RefPtr> : [Attachment 425698] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 10 21:23:07 PDT 2021


Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 224412: WebProcessPool should store Vector<Ref<WebProcessProxy>> instead of
Vector<RefPtr>
https://bugs.webkit.org/show_bug.cgi?id=224412

Attachment 425698: Patch

https://bugs.webkit.org/attachment.cgi?id=425698&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 425698
  --> https://bugs.webkit.org/attachment.cgi?id=425698
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425698&action=review

R=me with nits

> Source/WebKit/UIProcess/WebProcessPool.cpp:513
> +    Vector<Ref<WebProcessProxy>> processes = m_processes;

Auto ?

> Source/WebKit/UIProcess/WebProcessPool.cpp:904
> +    Vector<Ref<WebProcessProxy>> processes = m_processes;

Auto?

> Source/WebKit/UIProcess/WebProcessPool.cpp:1503
> +    Vector<Ref<WebProcessProxy>> processes = m_processes;

Auto?


More information about the webkit-reviews mailing list