[webkit-reviews] review denied: [Bug 224090] [CoreIPC] Encoding/decoding of WebCore::CapabilityValueOrRange transmits padding bytes : [Attachment 425558] Patch v4

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Apr 10 19:50:55 PDT 2021

Alex Christensen <achristensen at apple.com> has denied David Kilzer (:ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 224090: [CoreIPC] Encoding/decoding of WebCore::CapabilityValueOrRange
transmits padding bytes

Attachment 425558: Patch v4


--- Comment #17 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 425558
  --> https://bugs.webkit.org/attachment.cgi?id=425558
Patch v4

View in context: https://bugs.webkit.org/attachment.cgi?id=425558&action=review

> Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:319
> +	       WTFLogAlways("RealtimeMediaSource::supportsSizeAndFrameRate
failed width constraint, capabilities are [%d, %d]", *range.min, *range.max);

This also looks like it's unchecked dereferencing something.  Maybe an
Optional.  I don't think it should.  It should be 0 or the dereferenced value
like it was.

> Source/WebCore/platform/mediastream/RealtimeMediaSourceCapabilities.h:156
> +    Optional<CapabilityValueOrRange> m_width;

Why were these changed to Optional?

More information about the webkit-reviews mailing list