[webkit-reviews] review granted: [Bug 224377] Crash under WebProcessProxy::shouldSendPendingMessage() : [Attachment 425644] Patch

[bugzilla-daemon at webkit.org]

David Kilzer (:ddkilzer) <ddkilzer at webkit.org> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 224377: Crash under WebProcessProxy::shouldSendPendingMessage()
https://bugs.webkit.org/show_bug.cgi?id=224377

Attachment 425644: Patch

https://bugs.webkit.org/attachment.cgi?id=425644&action=review




--- Comment #5 from David Kilzer (:ddkilzer) <ddkilzer at webkit.org> ---
Comment on attachment 425644
  --> https://bugs.webkit.org/attachment.cgi?id=425644
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425644&action=review

r=me

> Source/WebKit/UIProcess/AuxiliaryProcessProxy.cpp:254
> -	   auto encoder = WTFMove(pendingMessage.encoder);
>	   auto sendOptions = pendingMessage.sendOptions;
>	   if (pendingMessage.asyncReplyInfo)
>	       IPC::addAsyncReplyHandler(*connection(),
pendingMessage.asyncReplyInfo->second,
WTFMove(pendingMessage.asyncReplyInfo->first));
> -	   m_connection->sendMessage(WTFMove(encoder), sendOptions);
> +	   m_connection->sendMessage(WTFMove(pendingMessage.encoder),
sendOptions);

Super nit:  Why not just inline `sendOptions` as well if you're inlining
`encoder`?  Or move it after the if statement?	Not necessary to change to
land, though.