[webkit-reviews] review denied: [Bug 224386] Consistently include JavaScriptCore's Inspector private interface headers : [Attachment 425647] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 9 13:55:32 PDT 2021


BJ Burg <bburg at apple.com> has denied Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 224386: Consistently include JavaScriptCore's Inspector private interface
headers
https://bugs.webkit.org/show_bug.cgi?id=224386

Attachment 425647: Patch

https://bugs.webkit.org/attachment.cgi?id=425647&action=review




--- Comment #4 from BJ Burg <bburg at apple.com> ---
Comment on attachment 425647
  --> https://bugs.webkit.org/attachment.cgi?id=425647
Patch

Thanks for this cleanup. Alas, your patch needs to include rebaselined code
generator results. Try `run-inspector-generator-tests --rebaseline`.

We forgot to update these results last time (with the (__bridge CFStringRef
change) so please ensure it's done this time.


More information about the webkit-reviews mailing list