[webkit-reviews] review granted: [Bug 224287] [iOS][FCR] Use context menus for text input datalist dropdowns : [Attachment 425414] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<akeerthi at apple.com>'s request for review:
Bug 224287: [iOS][FCR] Use context menus for text input datalist dropdowns
https://bugs.webkit.org/show_bug.cgi?id=224287

Attachment 425414: Patch

https://bugs.webkit.org/attachment.cgi?id=425414&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 425414
  --> https://bugs.webkit.org/attachment.cgi?id=425414
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425414&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:9817
> +    return [_dataListSuggestionsControl.getAutoreleased()
isShowingSuggestions];

Nit - I think you can remove the `.getAutoreleased()` here.

> Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:48
> + at property (nonatomic, readwrite) BOOL isShowingSuggestions;

Nit - I think you don't need the `readwrite` here, since @property is readwrite
by default.

> Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:479
> +	   [_suggestionsContextMenuInteraction
updateVisibleMenuWithBlock:[self](UIMenu *visibleMenu) -> UIMenu * {

Nit - I think you can just use & in the block capture and omit the `self->`
below, since this block is run synchronously.

> Source/WebKit/UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:594
> +	   if (strongSelf)

Nit - you can do `if (auto strongSelf = weakSelf.get())` here.