[webkit-reviews] review granted: [Bug 224337] [Metal-ANGLE] Support GPU power preferences, select low-power GPU by default. : [Attachment 425537] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Kyle Piddington
<kpiddington at apple.com>'s request for review:
Bug 224337: [Metal-ANGLE] Support GPU power preferences, select low-power GPU
by default.
https://bugs.webkit.org/show_bug.cgi?id=224337

Attachment 425537: Patch

https://bugs.webkit.org/attachment.cgi?id=425537&action=review




--- Comment #4 from Dean Jackson <dino at apple.com> ---
Comment on attachment 425537
  --> https://bugs.webkit.org/attachment.cgi?id=425537
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425537&action=review

> Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm:278
> +    //TODO: External GPU support. Do we prefer high power / low bandwidth
for general WebGL applications?
> +    //      Can we support hot-swapping in GPU's?

This is a good question. I would assume that if someone has an external GPU
they want to use it. And it is likely that their display is running through it
or, even if it's a laptop, they are using it as the primary display. So we
should probably use any external GPU before even checking for the
low-power/high-power flag. But this doesn't need to be fixed now.