[webkit-reviews] review granted: [Bug 224299] Make WebIDBServer not block main thread during initialization : [Attachment 425466] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 224299: Make WebIDBServer not block main thread during initialization
https://bugs.webkit.org/show_bug.cgi?id=224299

Attachment 425466: Patch

https://bugs.webkit.org/attachment.cgi?id=425466&action=review




--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 425466
  --> https://bugs.webkit.org/attachment.cgi?id=425466
Patch

r=me

Would be nice to RELEASE_ASSERT(!m_server) in the WebIDBServer destructor, to
prove that we have indeed called close().

Similary, would be nice to move the call to setCompletionCallback() into the
WebIDBServer server constructor. That way, the lifetime is more obvious, and we
always get object lifetime right even if we forget to call close().