[webkit-reviews] review granted: [Bug 224311] Add test infrastructure for app bound request context string : [Attachment 425451] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 224311: Add test infrastructure for app bound request context string
https://bugs.webkit.org/show_bug.cgi?id=224311

Attachment 425451: Patch

https://bugs.webkit.org/attachment.cgi?id=425451&action=review




--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 425451
  --> https://bugs.webkit.org/attachment.cgi?id=425451
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425451&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:60
> +static String contextString(NSURLRequest *) { return { }; }

What this returned a RegistrableDomain?

> LayoutTests/platform/ios-wk2/TestExpectations:1913
> +webkit.org/b/223750 [ Debug ]
security/contentSecurityPolicy/plugins-types-allows-youtube-plugin-replacement.
html [ Pass Crash ]

What a weird decision for your text editor to make!