[webkit-reviews] review granted: [Bug 224259] Nullptr dereference in ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline : [Attachment 425435] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Julian Gonzalez
<julian_a_gonzalez at apple.com>'s request for review:
Bug 224259: Nullptr dereference in
ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline
https://bugs.webkit.org/show_bug.cgi?id=224259

Attachment 425435: Patch

https://bugs.webkit.org/attachment.cgi?id=425435&action=review




--- Comment #6 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 425435
  --> https://bugs.webkit.org/attachment.cgi?id=425435
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425435&action=review

> LayoutTests/editing/inserting/insert-display-contents-crash.html:23
> +    document.execCommand('InsertHTML', false, '<h1>PASS');

Oh I mean that here, can do:
document.execCommand('InsertHTML', false, '<h1>This test passes if WebKit does
not crash. PASS');