[webkit-reviews] review granted: [Bug 224138] Use Hasher more, remove IntegerHasher, fix hashing-related mistakes : [Attachment 425430] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 7 14:42:40 PDT 2021


Chris Dumez <cdumez at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 224138: Use Hasher more, remove IntegerHasher, fix hashing-related mistakes
https://bugs.webkit.org/show_bug.cgi?id=224138

Attachment 425430: Patch

https://bugs.webkit.org/attachment.cgi?id=425430&action=review




--- Comment #10 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 425430
  --> https://bugs.webkit.org/attachment.cgi?id=425430
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425430&action=review

> Source/WebCore/platform/graphics/FontTaggedSettings.h:43
> +inline void add(Hasher& hasher, std::array<char, 4> array)

Could use FontTag?


More information about the webkit-reviews mailing list