[webkit-reviews] review granted: [Bug 224251] [webkitscmpy] Handle multiple double-branch commits : [Attachment 425333] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Apr 7 13:22:50 PDT 2021

dewei_zhu at apple.com has granted Jonathan Bedard <jbedard at apple.com>'s request
for review:
Bug 224251: [webkitscmpy] Handle multiple double-branch commits

Attachment 425333: Patch


--- Comment #4 from dewei_zhu at apple.com ---
Comment on attachment 425333
  --> https://bugs.webkit.org/attachment.cgi?id=425333

View in context: https://bugs.webkit.org/attachment.cgi?id=425333&action=review


>> Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:184
>> +				if default_count > 2:
> Are we making an assumption here that there will not be more than two
consecutive commits made to both on trunk and branch?

Discussed in person, we should probably add a comment to record this
assumption. And potentially increase the number. So far, 2 should work.

More information about the webkit-reviews mailing list