[webkit-reviews] review granted: [Bug 224268] [JSC] WasmMemory caging should care nullptr : [Attachment 425358] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 224268: [JSC] WasmMemory caging should care nullptr
https://bugs.webkit.org/show_bug.cgi?id=224268

Attachment 425358: Patch

https://bugs.webkit.org/attachment.cgi?id=425358&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 425358
  --> https://bugs.webkit.org/attachment.cgi?id=425358
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425358&action=review

r=me

> Source/JavaScriptCore/ChangeLog:3
> +	   [JSC] WasmMemory caging should care nullptr

"care about nullptr"?

> Source/JavaScriptCore/ChangeLog:10
> +	      This checking size can include redzone for fast-memory, but this
is OK: bound-check pass in LLInt (in upper tiers, we

"bounds-check"

> JSTests/ChangeLog:3
> +	   [JSC] WasmMemory caging should care nullptr

"care about"