[webkit-reviews] review granted: [Bug 224072] Introduce LexicalScopeFeatures to enable future bytecode optimizations : [Attachment 425040] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 224072: Introduce LexicalScopeFeatures to enable future bytecode
optimizations
https://bugs.webkit.org/show_bug.cgi?id=224072

Attachment 425040: Patch

https://bugs.webkit.org/attachment.cgi?id=425040&action=review




--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 425040
  --> https://bugs.webkit.org/attachment.cgi?id=425040
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425040&action=review

r=me with some nits.

> Source/JavaScriptCore/ChangeLog:9
> +	   statement, direct `eval`, or certain variable names only within the
current executable:

Typo: "to reason about" => "of reasoning about" and "of with statement" => "of
with statements"

> Source/JavaScriptCore/ChangeLog:27
> +	   If ResolveNode would know that unforgeable global properties are not
shadowed and there

Nit: "would know" => "knew"

> Source/JavaScriptCore/bytecode/UnlinkedFunctionExecutable.h:257
>      unsigned m_firstLineOffset : 31;

This probably shouldn't be a bit field or other bit fields should be shuffled
around to repack the struct.