[webkit-reviews] review granted: [Bug 224239] [WebXR] Introduce XRDeviceIdentifier and XRDeviceInfo to be used to communicate device info : [Attachment 425298] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 224239: [WebXR] Introduce XRDeviceIdentifier and XRDeviceInfo to be used to
communicate device info
https://bugs.webkit.org/show_bug.cgi?id=224239

Attachment 425298: Patch

https://bugs.webkit.org/attachment.cgi?id=425298&action=review




--- Comment #2 from Tim Horton <thorton at apple.com> ---
Comment on attachment 425298
  --> https://bugs.webkit.org/attachment.cgi?id=425298
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425298&action=review

> Source/WebKit/Shared/Cocoa/XRDeviceInfo.mm:41
> +    encoder << static_cast<uint64_t>(features.size());
> +    for (auto feature : features)
> +	   encoder << feature;

Odd, WebKit2's ArgumentCoders.h totally has a VectorArgumentCoder. Do you need
this custom implementation?