[webkit-reviews] review granted: [Bug 224235] [GStreamer] Only seek to change the rate un updatePlaybackRate() when needed : [Attachment 425284] Patch

[bugzilla-daemon at webkit.org]

Alicia Boya García <aboya at igalia.com> has granted Enrique Ocaña
<eocanha at igalia.com>'s request for review:
Bug 224235: [GStreamer] Only seek to change the rate un updatePlaybackRate()
when needed
https://bugs.webkit.org/show_bug.cgi?id=224235

Attachment 425284: Patch

https://bugs.webkit.org/attachment.cgi?id=425284&action=review




--- Comment #2 from Alicia Boya García <aboya at igalia.com> ---
Comment on attachment 425284
  --> https://bugs.webkit.org/attachment.cgi?id=425284
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425284&action=review

LGTM

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:539
> +	       m_lastPlaybackRate = m_playbackRate;

Add a documentation comment in the header file explaining this means the last
playback rate sent through a GStreamer seek.