[webkit-reviews] review granted: [Bug 223580] Use frameData instead of scheduleOnNextFrame calls in WebFakeXRDevice : [Attachment 423896] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Imanol Fernandez
<ifernandez at igalia.com>'s request for review:
Bug 223580: Use frameData instead of scheduleOnNextFrame calls in
WebFakeXRDevice
https://bugs.webkit.org/show_bug.cgi?id=223580

Attachment 423896: Patch

https://bugs.webkit.org/attachment.cgi?id=423896&action=review




--- Comment #3 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 423896
  --> https://bugs.webkit.org/attachment.cgi?id=423896
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423896&action=review

> Source/WebCore/testing/WebFakeXRDevice.cpp:63
> +void SimulatedXRDevice::setViews(Vector<Ref<FakeXRView>>&& views)

Does it need to be a &&?

> Source/WebCore/testing/WebFakeXRDevice.cpp:84
> +void SimulatedXRDevice::setViewerOrigin(Optional<FrameData::Pose>&& origin)

const Optional<>&

> Source/WebCore/testing/WebFakeXRDevice.cpp:89
> +	   m_frameData.isTrackingValid = true;

return here.

> Source/WebCore/testing/WebFakeXRDevice.cpp:138
> +    FrameData data = m_frameData;

Should we do FrameData data = WTFMove(m_frameData)?

> Source/WebCore/testing/WebFakeXRDevice.cpp:202
> +	       deviceViews.append(view.releaseReturnValue());

I would tend to remove the other setViews and create the FrameData::View object
here.

> Source/WebCore/testing/WebXRTest.cpp:57
> +	   simulatedDevice.setViews(WTFMove(views));

Cannot we directly call setViews(const Vector<FakeXRViewInit>&)