[webkit-reviews] review granted: [Bug 209163] [GStreamer][WebRTC] Audio is not played from an audio element when the srcObject object has unstarted video tracks : [Attachment 425092] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 209163: [GStreamer][WebRTC] Audio is not played from an audio element when
the srcObject object has unstarted video tracks
https://bugs.webkit.org/show_bug.cgi?id=209163

Attachment 425092: Patch

https://bugs.webkit.org/attachment.cgi?id=425092&action=review




--- Comment #3 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 425092
  --> https://bugs.webkit.org/attachment.cgi?id=425092
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425092&action=review

>
Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:63
1
> +	   if (track->type() == RealtimeMediaSource::Type::Video &&
!isVideoPlayer)

Nit: I prefer to add booleans first in evaluation cause you can short-circuit
some calls for the type(), etc.