[webkit-reviews] review granted: [Bug 224217] Remove RepaintLayoutRectsMap : [Attachment 425226] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 5 20:34:13 PDT 2021


zalan <zalan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 224217: Remove RepaintLayoutRectsMap
https://bugs.webkit.org/show_bug.cgi?id=224217

Attachment 425226: Patch

https://bugs.webkit.org/attachment.cgi?id=425226&action=review




--- Comment #2 from zalan <zalan at apple.com> ---
Comment on attachment 425226
  --> https://bugs.webkit.org/attachment.cgi?id=425226
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425226&action=review

great change.

> Source/WebCore/rendering/ComplexLineLayout.cpp:1328
> +	   if (!layoutContext().needsFullRepaint() &&
m_flow.hasSelfPaintingLayer() && m_flow.layerRepaintRects()) {

isn't m_flow.hasSelfPaintingLayer() redundant here (though maybe it provides
some information about the type of content (backed by a layer) we are dealing
here with).

> Source/WebCore/rendering/RenderLayer.h:224
> +	   return WTF::nullopt;

return { }; ?


More information about the webkit-reviews mailing list