[webkit-reviews] review granted: [Bug 224204] [iOS] contextmenu hints can be clipped by the WKWebView : [Attachment 425215] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 5 19:34:17 PDT 2021

Wenson Hsieh <wenson_hsieh at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 224204: [iOS] contextmenu hints can be clipped by the WKWebView

Attachment 425215: Patch


--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 425215
  --> https://bugs.webkit.org/attachment.cgi?id=425215

View in context: https://bugs.webkit.org/attachment.cgi?id=425215&action=review


> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7567
> +	   [self.textEffectsWindow

This /might/ be fine as-is...but since we're now inserting
`_targetedPreviewViewsContainerView` in a window that we don't own, it would
probably be a good idea to ensure that we remove it if the web view is removed
from the view hierarchy (and more generally, when we don't require it anymore).

More information about the webkit-reviews mailing list