[webkit-reviews] review granted: [Bug 224204] [iOS] contextmenu hints can be clipped by the WKWebView : [Attachment 425215] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 224204: [iOS] contextmenu hints can be clipped by the WKWebView
https://bugs.webkit.org/show_bug.cgi?id=224204

Attachment 425215: Patch

https://bugs.webkit.org/attachment.cgi?id=425215&action=review




--- Comment #7 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 425215
  --> https://bugs.webkit.org/attachment.cgi?id=425215
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425215&action=review

r=mews

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7567
> +	   [self.textEffectsWindow
addSubview:_targetedPreviewViewsContainerView.get()];

This /might/ be fine as-is...but since we're now inserting
`_targetedPreviewViewsContainerView` in a window that we don't own, it would
probably be a good idea to ensure that we remove it if the web view is removed
from the view hierarchy (and more generally, when we don't require it anymore).