[webkit-reviews] review granted: [Bug 222718] Nullptr crash in EventPath::eventTargetRespectingTargetRules : [Attachment 425146] Patch for landing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 5 14:34:24 PDT 2021

Ryosuke Niwa <rniwa at webkit.org> has granted Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 222718: Nullptr crash in EventPath::eventTargetRespectingTargetRules

Attachment 425146: Patch for landing


--- Comment #27 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 425146
  --> https://bugs.webkit.org/attachment.cgi?id=425146
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=425146&action=review

> LayoutTests/ChangeLog:1248
> +2021-04-01  Frédéric Wang	<fwang at igalia.com>

Please move the change log entry to the top.

> LayoutTests/editing/undo/undo-with-disconnected-editable-element-crash.js:20
> +    if (window.GCController) GCController.collect();

Can we reformat this function so that it's more readable?
Also, is this the simplest form we can reduce to? It seems like we ought to be
able to simplify it more?

> Source/WebCore/ChangeLog:2601
> +2021-04-01  Frédéric Wang	<fwang at igalia.com>


More information about the webkit-reviews mailing list