[webkit-reviews] review granted: [Bug 224051] Web Inspector: Grid overlay does not honor writing modes and RTL layout direction. : [Attachment 425194] Patch v1.0

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 5 13:49:06 PDT 2021


BJ Burg <bburg at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 224051: Web Inspector: Grid overlay does not honor writing modes and RTL
layout direction.
https://bugs.webkit.org/show_bug.cgi?id=224051

Attachment 425194: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=425194&action=review




--- Comment #5 from BJ Burg <bburg at apple.com> ---
Comment on attachment 425194
  --> https://bugs.webkit.org/attachment.cgi?id=425194
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=425194&action=review

r=me, nice work!

> Source/WebCore/inspector/InspectorOverlay.cpp:1673
> +	       startPoint = { isWritingModeFlipped ? contentBox.width() -
gridStartY : gridStartY, isDirectionFlipped ? contentBox.height() - x :x };

Nit: missing space in ':x'


More information about the webkit-reviews mailing list