[webkit-reviews] review granted: [Bug 133040] Migrate layout ascents and descents to LayoutUnits instead of ints : [Attachment 425188] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 5 12:53:44 PDT 2021


zalan <zalan at apple.com> has granted Rob Buis <rbuis at igalia.com>'s request for
review:
Bug 133040: Migrate layout ascents and descents to LayoutUnits instead of ints
https://bugs.webkit.org/show_bug.cgi?id=133040

Attachment 425188: Patch

https://bugs.webkit.org/attachment.cgi?id=425188&action=review




--- Comment #6 from zalan <zalan at apple.com> ---
Comment on attachment 425188
  --> https://bugs.webkit.org/attachment.cgi?id=425188
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425188&action=review

> Source/WebCore/rendering/RootInlineBox.cpp:819
> +	       LayoutUnit usedFontAscent = fontMetrics.ascent(baselineType());

It's up to you but as I mentioned in the previous patch I'd prefer uniform
initialization (and mention in the changelog that ascent/descent values are
still integral).


More information about the webkit-reviews mailing list