[webkit-reviews] review granted: [Bug 224191] REGRESSION(r267763) NetworkProcess never terminates : [Attachment 425178] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 5 11:41:41 PDT 2021

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 224191: REGRESSION(r267763) NetworkProcess never terminates

Attachment 425178: Patch


--- Comment #5 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 425178
  --> https://bugs.webkit.org/attachment.cgi?id=425178

View in context: https://bugs.webkit.org/attachment.cgi?id=425178&action=review

r=me with naming change.

> Source/WebKit/UIProcess/Network/NetworkProcessProxy.cpp:104
> +RefPtr<NetworkProcessProxy>& NetworkProcessProxy::defaultNetworkProcessPtr()

I think the WebKit pattern is:

I don't like the Ptr() naming. When I saw it, it really wasn't clear to me what
it meant.

If you don't like defaultNetworkProcessIfExists(), I guess we could call this
one defaultNetworkProcess() and the one below: ensureDefaultNetworkProcess().

More information about the webkit-reviews mailing list