[webkit-reviews] review granted: [Bug 224014] [Win][WK2] Implement IPC::Semaphore to run WebGL in GPU process : [Attachment 425140] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Fujii Hironori
<Hironori.Fujii at sony.com>'s request for review:
Bug 224014: [Win][WK2] Implement IPC::Semaphore to run WebGL in GPU process
https://bugs.webkit.org/show_bug.cgi?id=224014

Attachment 425140: Patch

https://bugs.webkit.org/attachment.cgi?id=425140&action=review




--- Comment #8 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 425140
  --> https://bugs.webkit.org/attachment.cgi?id=425140
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425140&action=review

r=me

Just have some comments on whether or not different guards might be more
appropriate here.

> Source/WebKit/Platform/IPC/StreamClientConnection.h:105
> +#if PLATFORM(COCOA) || PLATFORM(WIN)

Maybe a HAVE(IPC_SEMAPHORE) or something like that?

> Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp:116
> +#if PLATFORM(COCOA) || PLATFORM(WIN)
>  #include "RemoteGraphicsContextGLProxy.h"
>  #endif

Is there a better guard for this? Maybe an `ENABLE_WEBGL_IN_GPU_PROCESS`