[webkit-reviews] review granted: [Bug 224171] [WTF] Introduce FixedVector and use it for FixedOperands : [Attachment 425127] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Apr 5 09:44:10 PDT 2021
Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 224171: [WTF] Introduce FixedVector and use it for FixedOperands
https://bugs.webkit.org/show_bug.cgi?id=224171
Attachment 425127: Patch
https://bugs.webkit.org/attachment.cgi?id=425127&action=review
--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 425127
--> https://bugs.webkit.org/attachment.cgi?id=425127
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=425127&action=review
r=me
> Source/JavaScriptCore/llint/LLIntOffsetsExtractor.cpp:90
> using RefCountedArray = WTF::RefCountedArray<int>;
I think we can remove this now.
> Source/JavaScriptCore/runtime/CachedTypes.cpp:625
> + void encode(Encoder& encoder, const FixedVector<SourceType<T>>& vector)
It's a pity that we're copy-pasting this code 3 times. Can we use just one
template, and if needed, std::enable_if the container type to be one of the 3
acceptable types?
> Source/JavaScriptCore/runtime/CachedTypes.cpp:658
> + void decode(Decoder& decoder, FixedVector<SourceType<T>>& vector,
Args... args) const
Ditto.
More information about the webkit-reviews
mailing list