[webkit-reviews] review denied: [Bug 224099] [WPE] Enable Cog's GTK4 backend : [Attachment 424999] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 5 05:38:06 PDT 2021


Adrian Perez <aperez at igalia.com> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 224099: [WPE] Enable Cog's GTK4 backend
https://bugs.webkit.org/show_bug.cgi?id=224099

Attachment 424999: Patch

https://bugs.webkit.org/attachment.cgi?id=424999&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 424999
  --> https://bugs.webkit.org/attachment.cgi?id=424999
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=424999&action=review

> Tools/Scripts/webkitpy/port/wpe.py:155
> +		   args = ['-P', 'gtk4'] + args

If somebody passes “--platform=foo”, then the final command line will end
up with “--platform=foo -P gtk4”. It would be good to add a check here for
that. For example, from the top of my mind (that is, untested):

  has_platform_arg = any((a == "-P" or a.startswith("--platform=") for a in
args))
  if not has_platform_arg:
      args.insert(0, "--platform=gtk4")


More information about the webkit-reviews mailing list