[webkit-reviews] review granted: [Bug 223882] [Flatpak SDK] Enable LLVM extension : [Attachment 424630] Patch

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 223882: [Flatpak SDK] Enable LLVM extension
https://bugs.webkit.org/show_bug.cgi?id=223882

Attachment 424630: Patch

https://bugs.webkit.org/attachment.cgi?id=424630&action=review




--- Comment #2 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 424630
  --> https://bugs.webkit.org/attachment.cgi?id=424630
Patch

Patch LGTM with a couple of small nits :)

View in context: https://bugs.webkit.org/attachment.cgi?id=424630&action=review

> Tools/flatpak/flatpakutils.py:736
> +		   building = os.path.basename(args[0]).startswith("build")

This check looks a bit brittle, but other than using “in ("build-webkit",
"build-jsc")” to
check for a well-known list of possible build scripts, I don't really have a
better idea ��️

> Tools/flatpak/flatpakutils.py:988
> +	       clang_archive, clang_toolchaines = self.pack_toolchain(("clang",
"clang++"), {"/usr/bin/clang++": "clang++",

Typo in variable name: clanf_toolchaines → clang_toolchains