[webkit-reviews] review requested: [Bug 222718] Nullptr crash in EventPath::eventTargetRespectingTargetRules : [Attachment 425142] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Apr 5 02:25:39 PDT 2021


Frédéric Wang (:fredw) <fred.wang at free.fr> has asked  for review:
Bug 222718: Nullptr crash in EventPath::eventTargetRespectingTargetRules
https://bugs.webkit.org/show_bug.cgi?id=222718

Attachment 425142: Patch

https://bugs.webkit.org/attachment.cgi?id=425142&action=review




--- Comment #23 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Created attachment 425142

  --> https://bugs.webkit.org/attachment.cgi?id=425142&action=review

Patch

Here is a patch but I writing the regression test is a bit difficult :

- If I run with --repeat=XXX, only the first run has the "B" in the
-expected.txt
- If I add waitUntilDone/notifyDone, expectation is no longer flaky ("B" is
always absent from the output) but the test does not allow to reproduce the
crash.

Is it possible to run a crash test without an -expected.txt ?


More information about the webkit-reviews mailing list