[webkit-reviews] review granted: [Bug 222518] Reduce compile time and binary size cost of enabling proper CSSStyleDeclaration property access behavior : [Attachment 425108] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Sam Weinig <sam at webkit.org>'s request
for review:
Bug 222518: Reduce compile time and binary size cost of enabling proper
CSSStyleDeclaration property access behavior
https://bugs.webkit.org/show_bug.cgi?id=222518

Attachment 425108: Patch

https://bugs.webkit.org/attachment.cgi?id=425108&action=review




--- Comment #16 from Darin Adler <darin at apple.com> ---
Comment on attachment 425108
  --> https://bugs.webkit.org/attachment.cgi?id=425108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425108&action=review

r=me assuming tests pass (seeing EWS api-gtk failing right now?), there are not
other scaling issues other than compile time and binary size, and this does
resolve both of those issues as claimed

> Source/WebCore/bindings/js/JSDOMAttribute.h:61
> +    static bool setPassingPropertyName(JSC::JSGlobalObject&
lexicalGlobalObject, JSC::EncodedJSValue thisValue, JSC::EncodedJSValue
encodedValue, JSC::PropertyName attributeName)

Given overloading, can’t this be named set? Or do template arguments not do the
overloading thing?

> LayoutTests/ChangeLog:14
> +	   Remove tests for iteration order, which is not standardized, and not
consistent among
> +	   browsers.

But stability still seems desirable, so I’d kind of still wish for a test.