[webkit-reviews] review granted: [Bug 224140] [macOS] Add MediaSessionCoordinator API test : [Attachment 425101] WIP, with state change tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Apr 4 11:25:30 PDT 2021


Jer Noble <jer.noble at apple.com> has granted  review:
Bug 224140: [macOS] Add MediaSessionCoordinator API test
https://bugs.webkit.org/show_bug.cgi?id=224140

Attachment 425101: WIP, with state change tests

https://bugs.webkit.org/attachment.cgi?id=425101&action=review




--- Comment #6 from Jer Noble <jer.noble at apple.com> ---
Comment on attachment 425101
  --> https://bugs.webkit.org/attachment.cgi?id=425101
WIP, with state change tests

View in context: https://bugs.webkit.org/attachment.cgi?id=425101&action=review

> Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm:68
> -void WebKit::NetworkSessionCocoa::removeNetworkWebsiteData(WallTime,
CompletionHandler<void()>&& completionHandler) { completionHandler(); }
> +void WebKit::NetworkSessionCocoa:: (WallTime, CompletionHandler<void()>&&
completionHandler) { completionHandler(); }

This looks accidental.


More information about the webkit-reviews mailing list