[webkit-reviews] review granted: [Bug 224162] [JSC] Shrink some of Vectors in JSC : [Attachment 425121] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 224162: [JSC] Shrink some of Vectors in JSC
https://bugs.webkit.org/show_bug.cgi?id=224162

Attachment 425121: Patch

https://bugs.webkit.org/attachment.cgi?id=425121&action=review




--- Comment #11 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 425121
  --> https://bugs.webkit.org/attachment.cgi?id=425121
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425121&action=review

> Source/JavaScriptCore/bytecode/GetterSetterAccessCase.cpp:44
> +GetterSetterAccessCase::GetterSetterAccessCase(VM& vm, JSCell* owner,
AccessType accessType, CacheableIdentifier identifier, PropertyOffset offset,
Structure* structure, const ObjectPropertyConditionSet& conditionSet, bool
viaProxy, WatchpointSet* additionalSet, JSObject* customSlotBase,
RefPtr<PolyProtoAccessChain> prototypeAccessChain)

Should that be a RefPtr<>&&?

> Source/JavaScriptCore/bytecode/GetterSetterAccessCase.h:59
> +	   JSObject* customSlotBase, Optional<DOMAttributeAnnotation>,
RefPtr<PolyProtoAccessChain>);

RefPtr<>&&?

> Source/JavaScriptCore/bytecode/GetterSetterAccessCase.h:62
> +	   const ObjectPropertyConditionSet&, RefPtr<PolyProtoAccessChain>,
bool viaProxy = false,

Ditto

> Source/JavaScriptCore/bytecode/GetterSetterAccessCase.h:73
> +    GetterSetterAccessCase(VM&, JSCell*, AccessType, CacheableIdentifier,
PropertyOffset, Structure*, const ObjectPropertyConditionSet&, bool viaProxy,
WatchpointSet* additionalSet, JSObject* customSlotBase,
RefPtr<PolyProtoAccessChain>);

Ditto

> Source/JavaScriptCore/bytecode/IntrinsicGetterAccessCase.cpp:36
> +IntrinsicGetterAccessCase::IntrinsicGetterAccessCase(VM& vm, JSCell* owner,
CacheableIdentifier identifier, PropertyOffset offset, Structure* structure,
const ObjectPropertyConditionSet& conditionSet, JSFunction* intrinsicFunction,
RefPtr<PolyProtoAccessChain> prototypeAccessChain)

Ditto

> Source/JavaScriptCore/bytecode/IntrinsicGetterAccessCase.cpp:42
> +std::unique_ptr<AccessCase> IntrinsicGetterAccessCase::create(VM& vm,
JSCell* owner, CacheableIdentifier identifier, PropertyOffset offset,
Structure* structure, const ObjectPropertyConditionSet& conditionSet,
JSFunction* intrinsicFunction, RefPtr<PolyProtoAccessChain>
prototypeAccessChain)

Ditto

> Source/JavaScriptCore/bytecode/IntrinsicGetterAccessCase.h:45
> +    static std::unique_ptr<AccessCase> create(VM&, JSCell*,
CacheableIdentifier, PropertyOffset, Structure*, const
ObjectPropertyConditionSet&, JSFunction* intrinsicFunction,
RefPtr<PolyProtoAccessChain>);

Ditto

> Source/JavaScriptCore/bytecode/IntrinsicGetterAccessCase.h:52
> +    IntrinsicGetterAccessCase(VM&, JSCell*, CacheableIdentifier,
PropertyOffset, Structure*, const ObjectPropertyConditionSet&, JSFunction*
intrinsicFunction, RefPtr<PolyProtoAccessChain>);

Ditto

> Source/JavaScriptCore/bytecode/ProxyableAccessCase.cpp:41
> +std::unique_ptr<AccessCase> ProxyableAccessCase::create(VM& vm, JSCell*
owner, AccessType type, CacheableIdentifier identifier, PropertyOffset offset,
Structure* structure, const ObjectPropertyConditionSet& conditionSet, bool
viaProxy, WatchpointSet* additionalSet, RefPtr<PolyProtoAccessChain>
prototypeAccessChain)

Ditto