[webkit-reviews] review granted: [Bug 224124] Allow the WebAuthn UI to inform users about BiometryLockout : [Attachment 425043] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 224124: Allow the WebAuthn UI to inform users about BiometryLockout
https://bugs.webkit.org/show_bug.cgi?id=224124

Attachment 425043: Patch

https://bugs.webkit.org/attachment.cgi?id=425043&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 425043
  --> https://bugs.webkit.org/attachment.cgi?id=425043
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=425043&action=review

The test failures on iOS-wk2 don't seem related to this change. r=me

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalService.mm:49
> +    if ((!result || error) && error.code != LAErrorBiometryLockout) {

Should we present any kind of message if the error is LAErrorBiometryLockout?
How does the user recover?