[webkit-reviews] review granted: [Bug 224119] Add WKURLSchemeTask redirect API : [Attachment 425045] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 2 14:04:46 PDT 2021

Alex Christensen <achristensen at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 224119: Add WKURLSchemeTask redirect API

Attachment 425045: Patch


--- Comment #5 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 425045
  --> https://bugs.webkit.org/attachment.cgi?id=425045

View in context: https://bugs.webkit.org/attachment.cgi?id=425045&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKURLSchemeTask.h:39
> +/*! @abstract Mark the task as redirected.

Indicate that the task was redirected.
If it were just marking, it wouldn't need a completion handler.

> Source/WebKit/UIProcess/API/Cocoa/WKURLSchemeTask.mm:105
> +    auto function = [protectedSelf = retainPtr(self), self,
protectedResponse = retainPtr(response), response, protectedRequest =
retainPtr(request), request, innerCompletionHandler =
WTFMove(innerCompletionHandler)] () mutable {

It seems unnecessary to doubly wrap this block.

More information about the webkit-reviews mailing list