[webkit-reviews] review granted: [Bug 223636] REGRESSION(r274358) [GStreamer] http/tests/images/mp4-partial-load.html is flaky crashing inside GStreamer : [Attachment 424503] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Apr 2 10:26:20 PDT 2021


Carlos Alberto Lopez Perez <clopez at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 223636: REGRESSION(r274358) [GStreamer]
http/tests/images/mp4-partial-load.html is flaky crashing inside GStreamer
https://bugs.webkit.org/show_bug.cgi?id=223636

Attachment 424503: Patch

https://bugs.webkit.org/attachment.cgi?id=424503&action=review




--- Comment #7 from Carlos Alberto Lopez Perez <clopez at igalia.com> ---
Comment on attachment 424503
  --> https://bugs.webkit.org/attachment.cgi?id=424503
Patch

Patch looks fine.
I tested it fixes the crash on http/tests/images/mp4-partial-load.html and it
also fixes the flaky crashes on media/video-as-img-output-pts.html and
fast/images/animated-image-mp4-crash.html
Please remove this two tests from the glib TestExpectations file (that I added
on r275423) when landing.


More information about the webkit-reviews mailing list