[webkit-reviews] review granted: [Bug 223899] v2: REGRESSION(r266890): [Cocoa] Fix API::InspectorClient leak : [Attachment 424958] Patch v2.2 - address Devin feedback

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted BJ Burg <bburg at apple.com>'s
request for review:
Bug 223899: v2: REGRESSION(r266890): [Cocoa] Fix API::InspectorClient leak
https://bugs.webkit.org/show_bug.cgi?id=223899

Attachment 424958: Patch v2.2 - address Devin feedback

https://bugs.webkit.org/attachment.cgi?id=424958&action=review




--- Comment #9 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 424958
  --> https://bugs.webkit.org/attachment.cgi?id=424958
Patch v2.2 - address Devin feedback

View in context: https://bugs.webkit.org/attachment.cgi?id=424958&action=review

r=me

> Source/WebKit/UIProcess/API/APIInspectorClient.h:41
> -    virtual void openURLExternally(WebKit::WebInspectorUIProxy&, const
WTF::String& url) { }
> +    virtual void openURLExternally(WebKit::WebInspectorUIProxy&, const
WTF::String& url) { };

oops